This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Add fixes for problems discovered by xunit.analyzers #1999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
commented
Aug 15, 2017
| @@ -1183,9 +1183,8 @@ public void AbortingTheConnectionSendsFIN() | |||
| } | |||
| } | |||
|
|
|||
| [Theory] | |||
| [MemberData(nameof(ConnectionAdapterData))] | |||
| public async Task HeadersAndStreamsAreReusedAcrossRequests(ListenOptions listenOptions) | |||
halter73
approved these changes
Aug 16, 2017
| @@ -335,7 +335,9 @@ public void InitializeStreamsResetsStreams() | |||
| string requestLine, | |||
| string expectedMethod, | |||
| string expectedRawTarget, | |||
| #pragma warning disable xUnit1026 // Theory methods should use all of their parameters | |||
There was a problem hiding this comment.
Comment that it's sharing theory data with with HttpParserTests.ParsesRequestLine.
| @@ -26,8 +26,10 @@ public class HttpParserTests | |||
| string expectedMethod, | |||
| string expectedRawTarget, | |||
| string expectedRawPath, | |||
| #pragma warning disable xUnit1026 // Theory methods should use all of their parameters | |||
There was a problem hiding this comment.
Comment that it's sharing theory data with FrameTests.TakeStartLineSetsFrameProperties.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of xunit.analyzers found a few interesting places where we had theory parameters that were never actually used. These changes will be required before upgrading to xunit 2.3.0-beta4 (cref aspnet/Universe#540)