This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Remove ConfigureDefaultOptions #1886
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DamianEdwards @danroth27 are we sure about this one? The default binders do not work for Kestrel. |
|
Yes, the config support for kestrel is getting pulled for 2.0. |
6 tasks
Tratcher
suggested changes
Jun 5, 2017
| @@ -14,7 +14,6 @@ | |||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.AspNetCore.Certificates.Configuration.Sources" Version="$(AspNetCoreVersion)" PrivateAssets="All" /> | |||
There was a problem hiding this comment.
No longer used?
@javiercn are you going to use Microsoft.AspNetCore.Certificates.Configuration.Sources in Identity? If not, should it be removed from Hosting for now?
There was a problem hiding this comment.
Remove Kestrel.Https as well, it was only added for config binding
|
Reverted the original change instead #1875 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.