This repository was archived by the owner on Dec 18, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 523
Delay loading the default development certificate #2422
Labels
Milestone
Comments
Costing? |
Merged
Once we have the SNI callback then we can use it here. |
No, this is later than we'd want, and invoked per connection. You want to load the cert as the server starts, but only if no other cert was provided. |
Disagree. You want to load the cert only if you’re using https. |
Yes, but inside the SNI callback is way too late. Do it when you set up HTTPS. One of these two places seems the most likely:
|
Tratcher
added a commit
that referenced
this issue
Apr 4, 2018
Tratcher
added a commit
that referenced
this issue
Apr 4, 2018
Tratcher
added a commit
that referenced
this issue
Apr 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Today Kestrel first tries to load the default development certificate and assign that to all new HttpsConnectionAdapterOptions.ServerCertificate.
This shows up as a measurable % of startup time. It also causes log noise.
It also causes additional complexities with the new SNI support were the cert and the cert selector are mutually exclusive. This may need to get refactored as part of #2357
The text was updated successfully, but these errors were encountered: