This repository was archived by the owner on Mar 19, 2019. It is now read-only.
React to HttpContextFactory constructor change
#184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @Tratcher @davidfowl this is the only thing that breaks due to aspnet/HttpAbstractions#594. |
| // Microsoft.Net.Http.Server. | ||
| private const int BasePort = 5001; | ||
| private const int MaxPort = 8000; | ||
| private static int NextPort = BasePort; | ||
| private static object PortLock = new object(); | ||
| private static IHttpContextFactory Factory = new HttpContextFactory(new HttpContextAccessor()); | ||
| private static IHttpContextFactory Factory = new HttpContextFactory( |
There was a problem hiding this comment.
I don't see this field used anywhere. Am I missing something?
There was a problem hiding this comment.
Nope and removing this field is so much simpler 😺
|
🆙📅 |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringBuilderto reduce allocations when adding response cookies HttpAbstractions#594 and issueResponseCookies.Append()allocates lots, big lots HttpAbstractions#561