Flaky test: RequestBody_ReadAsync_Success

[ryanbrandenburg]

This test fails occasionally with the following error:

System.TimeoutException : AcceptAsync has timed out.
   at Microsoft.AspNetCore.Server.HttpSys.Listener.Utilities.AcceptAsync(HttpSysListener server, TimeSpan timeout) in /_/test/Microsoft.AspNetCore.Server.HttpSys.FunctionalTests/Listener/Utilities.cs:line 108
   at Microsoft.AspNetCore.Server.HttpSys.Listener.RequestBodyTests.RequestBody_ReadAsync_Success() in /_/test/Microsoft.AspNetCore.Server.HttpSys.FunctionalTests/Listener/RequestBodyTests.cs:line 73
--- End of stack trace from previous location where exception was thrown ---

[Tratcher]

History:
http://aspnetci/project.html?projectId=XPlat&buildTypeId=&tab=testDetails&testNameId=-5284826571007502406&order=TEST_STATUS_DESC&branch_XPlat=__all_branches__&itemsCount=50

18 failures since Feb 6, all on 2008R2 - Possible agent issue?

[ryanbrandenburg]

What would the issue on the agent be that would cause this behavior?

[Tratcher]

I don't know but it's suspicious that this only fails on 2008R2 and not Win7, they're the same OS. And we only have one agent for 2008R2 so it's hard to rule out an agent issue.

[ryanbrandenburg]

RequestBody_ReadAsync_Success failed again.

This comment was made automatically. If there is a problem contact @ryanbrandenburg.

[ryanbrandenburg]

AuthTypes_AllowAnonymous_NoChallenge failed again.

This comment was made automatically. If there is a problem contact @ryanbrandenburg.

[Eilon]

@Tratcher - please take a look at this issue because it has been failing again.

[ryanbrandenburg]

RequestBody_ReadAsync_Success failed with about the same error.
AuthTypes_AllowAnonymous_NoChallenge failed with about the same error.
AuthTypes_AllowAnonymous_NoChallenge failed with about the same error.

This comment was made automatically. If there is a problem contact @ryanbrandenburg.

[Tratcher]

AppVeyor failures captured with the new tracing:

[xUnit.net 00:00:15.78]     Microsoft.AspNetCore.Server.HttpSys.Listener.ResponseCachingTests.Caching_VariousUnsupportedRequestMethods_NotCached(method: "UNKNOWN") [FAIL]
  Failed   Microsoft.AspNetCore.Server.HttpSys.Listener.ResponseCachingTests.Caching_VariousUnsupportedRequestMethods_NotCached(method: "UNKNOWN")
  Error Message:
   System.InvalidOperationException : The response completed prematurely: StatusCode: 503, ReasonPhrase: 'Service Unavailable', Version: 1.1, Content: System.Net.Http.HttpConnection+HttpConnectionResponseContent, Headers:
  {
    Server: Microsoft-HTTPAPI/2.0
    Date: Fri, 03 Aug 2018 22:50:48 GMT
    Connection: close
    Content-Type: text/html; charset=us-ascii
    Content-Length: 326
  }
  Stack Trace:
     at Microsoft.AspNetCore.Server.HttpSys.Listener.Utilities.Before[T](Task`1 acceptTask, Task`1 responseTask) in /_/test/Microsoft.AspNetCore.Server.HttpSys.FunctionalTests/Listener/Utilities.cs:line 123
     at Microsoft.AspNetCore.Server.HttpSys.Listener.ResponseCachingTests.Caching_VariousUnsupportedRequestMethods_NotCached(String method) in /_/test/Microsoft.AspNetCore.Server.HttpSys.FunctionalTests/Listener/ResponseCachingTests.cs:line 623
  --- End of stack trace from previous location where exception was thrown ---
  Results File: C:\projects\httpsysserver\artifacts\logs\UnitTests-netcoreapp2.2-t000.trx

Microsoft.AspNetCore.Server.HttpSys.Listener.ResponseHeaderTests.AddingControlCharactersToHeadersThrows(key: "\r\nServer", value: "Data") [FAIL]
  Failed   Microsoft.AspNetCore.Server.HttpSys.Listener.ResponseHeaderTests.AddingControlCharactersToHeadersThrows(key: "\r\nServer", value: "Data")
  Error Message:
   System.InvalidOperationException : The response completed prematurely: StatusCode: 503, ReasonPhrase: 'Service Unavailable', Version: 1.1, Content: System.Net.Http.StreamContent, Headers:
  {
    Connection: close
    Date: Fri, 03 Aug 2018 22:51:21 GMT
    Server: Microsoft-HTTPAPI/2.0
    Content-Length: 326
    Content-Type: text/html; charset=us-ascii
  }
  Stack Trace:
     at Microsoft.AspNetCore.Server.HttpSys.Listener.Utilities.<Before>d__15`1.MoveNext()
  --- End of stack trace from previous location where exception was thrown ---
     at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
     at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
     at Microsoft.AspNetCore.Server.HttpSys.Listener.ResponseHeaderTests.<AddingControlCharactersToHeadersThrows>d__18.MoveNext()
  --- End of stack trace from previous location where exception was thrown ---
     at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
     at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
  --- End of stack trace from previous location where exception was thrown ---
     at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
     at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
  --- End of stack trace from previous location where exception was thrown ---
     at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
     at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

The server successfully started, there's no indication of why the client would randomly get a 503. I'll see if we get similar failures out of the main builds.

Possible mitigations:

• Start the AcceptAsync before starting the client SendAsync.
• Ask the HttpSys team if there is some initialization race where the server is not immediately available after Start.

[ryanbrandenburg]

RequestBody_ReadAsync_Success failed with about the same error.

This comment was made automatically. If there is a problem contact @ryanbrandenburg.