Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Provide a default constructor for DefaultHttpContext. #98

Merged
merged 1 commit into from
Jul 8, 2014
Merged

Provide a default constructor for DefaultHttpContext. #98

merged 1 commit into from
Jul 8, 2014

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Jul 7, 2014

#91

@davidfowl
Copy link
Member

I'm not sure this is enough to declare this testable (it's a start though). Let's try to get some examples of providing a form and query string without having to declare extra types.

I'd like @pranavkm @halter73@rynowak @harshgMSFT to chime in here since they have been writing unit tests agains the new HttpAbstractions. The goal here is the make it easy across the board so that frameworks like Mvc and SignalR can do it as well as end users wanting to test their controllers/hubs etc.

@Tratcher
Copy link
Member Author

Tratcher commented Jul 8, 2014

Then we should merge this PR and start new ones for the additional feature work.


From: David Fowlermailto:[email protected]
Sent: ‎7/‎7/‎2014 10:21 PM
To: aspnet/HttpAbstractionsmailto:[email protected]
Cc: Chris Rmailto:[email protected]
Subject: Re: [HttpAbstractions] Provide a default constructor for DefaultHttpContext. (#98)

I'm not sure this is enough to declare this testable (it's a start though). Let's try to get some examples of providing a form and query string without having to declare extra types.

I'd like @pranavkm @halter73@rynowak @harshgMSFT to chime in here since they have been writing unit tests agains the new HttpAbstractions. The goal here is the make it easy across the board so that frameworks like Mvc and SignalR can do it as well as end users wanting to test their controllers/hubs etc.


Reply to this email directly or view it on GitHub:
#98 (comment)

@davidfowl
Copy link
Member

@Tratcher Sure, this PR is fine but the bug is about making the context more testable in general. I'll move the discussion to the bug instead of this PR.

@Tratcher Tratcher merged commit 5bf4883 into aspnet:dev Jul 8, 2014
@Tratcher Tratcher deleted the Testable branch July 16, 2014 23:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants