This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Fix GetToken #824
Closed
Fix GetToken #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
approved these changes
Apr 24, 2017
| @@ -24,6 +24,7 @@ public static IServiceCollection AddAuthenticationCore(this IServiceCollection s | |||
| throw new ArgumentNullException(nameof(services)); | |||
| } | |||
|
|
|||
| services.AddOptions(); | |||
There was a problem hiding this comment.
Hosting always adds this, no? If you're just adding it for tests then add it in the tests.
There was a problem hiding this comment.
Yup just for tests, sure I can move to there I guess
| @@ -117,7 +122,68 @@ public void UpdateTokenValueReturnsFalseForUnknownToken() | |||
| Assert.Null(props.GetTokenValue("ONE")); | |||
| Assert.Null(props.GetTokenValue("Jigglypuff")); | |||
There was a problem hiding this comment.
Guessing your family doen't play pokemon go :)
There was a problem hiding this comment.
Oh I recognized it. Testing on Pokemon is ethically discouraged, that's what Chell is for.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #823
@Tratcher