This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Switch to GetAuthenticationInfoAsync #616
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note this is a breaking change and all uses of |
|
Not rc2? |
| /// <summary> | ||
| /// The <see cref="ClaimsPrincipal"/>. | ||
| /// </summary> | ||
| public ClaimsPrincipal Principal { get; set; } |
There was a problem hiding this comment.
Curious: is there any particular reason to use publicly settable properties instead of get-only properties + public constructor?
There was a problem hiding this comment.
No particular reason, if you guys feel strongly this should be readonly ctor properties, easy enough change.
|
@Tratcher any final concerns with this? |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #572
@Tratcher @Eilon