This repository was archived by the owner on Nov 20, 2018. It is now read-only.
[Proposal] Generic accessor into feature collection #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public TFeature Get<TFeature>() | ||
| { | ||
| var type = typeof(TFeature); | ||
| if (type.GetTypeInfo().IsValueType) |
There was a problem hiding this comment.
(TFeature)this[type] blows up if its a struct and not in the collection with a NRE
benaadams
added a commit
to benaadams/KestrelHttpServer
that referenced
this pull request
Dec 31, 2015
Other half of aspnet/HttpAbstractions#525 Haven't changed the code generator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also making the FeatureInterfaces structs public and checking for those means the
IGetConcreteStructWrappedfast path can be done inFrame.FastFeatureGet<T>(half speed of having no branches)Resolves #522