Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Register FileBufferingReadStream for disposal #520

Merged
merged 1 commit into from
Dec 23, 2015
Merged

Register FileBufferingReadStream for disposal #520

merged 1 commit into from
Dec 23, 2015

Conversation

BrennanConroy
Copy link
Member

Tratcher
Tratcher reviewed Dec 23, 2015
View reviewed changes
src/Microsoft.AspNet.Http/BufferingHelper.cs
@@ -50,7 +50,9 @@ public static HttpRequest EnableRewind(this HttpRequest request, int bufferThres
{
// TODO: Register this buffer for disposal at the end of the request to ensure the temp file is deleted.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the TODO

@Tratcher
Copy link
Member

:shipit:

@BrennanConroy BrennanConroy merged commit ee804e5 into dev Dec 23, 2015
@BrennanConroy BrennanConroy deleted the brecon/dispose branch December 23, 2015 00:15
@BrennanConroy BrennanConroy mentioned this pull request Dec 23, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrennanConroy @Tratcher @dnfclas