This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Set default path=/ when removing cookie #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pakrym, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
|
|
|
Weird we had that much logic that could be readily deleted 😄 /cc @Tratcher |
pakrym
force-pushed
the
pakrym/remove-cookie
branch
from
f0108cd to
fa5d9fa
Compare
|
@davidfowl It has been like that sense Katana, @lodejard did it as a perf optimization because the logic was much simpler for that scenario. |
| string cookieHeaderValue = headers[HeaderNames.SetCookie]; | ||
| Assert.StartsWith(testcookie, cookieHeaderValue); | ||
| Assert.Contains("path=/", cookieHeaderValue); | ||
| } |
There was a problem hiding this comment.
Also add a test where Append adds the cookie and then Delete removes it.
|
🆙 📅 |
|
|
1 similar comment
|
|
pakrym
force-pushed
the
pakrym/remove-cookie
branch
from
e840e31 to
690e5a6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#437
/cc @Tratcher @JunTaoLuo @halter73