-
Notifications
You must be signed in to change notification settings - Fork 191
Allow DefaultHttpContext to be pooled [Design] #404
Conversation
Hi @benaadams, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
@@ -168,8 +185,26 @@ public override void Abort() | |||
|
|||
public override void Dispose() | |||
{ | |||
// REVIEW: is this necessary? is the environment "owned" by the context? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -109,5 +114,13 @@ public override IEnumerable<AuthenticationDescription> GetAuthenticationSchemes( | |||
throw new InvalidOperationException($"The following authentication scheme was not accepted: {authenticationScheme}"); | |||
} | |||
} | |||
|
|||
public void Dispose() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reset
See #402 (comment) for details on server run improvements (61.5k rps -> 1.49M rps) |
@@ -116,5 +121,14 @@ public override void Redirect(string location, bool permanent) | |||
|
|||
Headers[HeaderNames.Location] = location; | |||
} | |||
|
|||
public void Dispose() | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reset
Closing this as discussed with @benaadams |
Half of #402 needs change to Hosting also