Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Put core middleware "together" #44

Closed
davidfowl opened this issue Apr 16, 2014 · 4 comments
Closed

Put core middleware "together" #44

davidfowl opened this issue Apr 16, 2014 · 4 comments
Assignees
Milestone

Comments

@davidfowl
Copy link
Member

This still needs some design work but these middleware a core to pretty much every application:

  • Map
  • Run
  • UseMiddleware(middlewareType)
  • UseServices

There could be a meta package that brings these in.

@davidfowl davidfowl added this to the Alpha milestone Apr 16, 2014
@Tratcher
Copy link
Member

Use(middleareType, args) and UseContainer are currently in the Hosting repo in the Microsoft.AspNet.RequestContainer assembly.

Run is currently implemented directly on the IBuilder interface.

Recommendation:

  • Rename this assembly to Microsoft.AspNet.Pipeline and move it to the HttpAbstractions repo.
  • Add Map to this assembly
  • Move Run to this assembly

@Tratcher
Copy link
Member

Updated proposal:

  • Implement Map and Run in HttpAbstractions
  • UseMiddleware and UseServices have DI dependencies, so leave them where they are or move them to the new BuilderComposition repo.

@Tratcher
Copy link
Member

#20 Complete for Map, Run, and Use.

Now what do we do with UseMiddleware and UseServices?

@glennc
Copy link
Member

glennc commented May 19, 2014

Leaving these where they are for now, there will be reviews later that will revisit them.

@glennc glennc closed this as completed May 19, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants