Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Consider making IFormFileCollection read-only #365

Closed
rynowak opened this issue Aug 6, 2015 · 2 comments
Closed

Consider making IFormFileCollection read-only #365

rynowak opened this issue Aug 6, 2015 · 2 comments
Assignees
@rynowak
Labels
enhancement

Comments

@rynowak
Copy link
Member

rynowak commented Aug 6, 2015

IFormCollection is readonly, IFormFileCollection is not.

https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNet.Http.Abstractions/IFormCollection.cs
https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNet.Http.Abstractions/IFormFileCollection.cs

This is a bit of a speedbump for fixing aspnet/Mvc#2527 and would otherwise require us to duplicate the code in FormFileCollection.
@Tratcher
Copy link
Member

Tratcher commented Aug 6, 2015

The problem is just that IFormFileCollection implements IList<IFormFile>, right? You just want something more like IReadableStringCollection?

@rynowak
Copy link
Member Author

rynowak commented Aug 6, 2015

preferably IReadOnlyList<IFormFile

@glennc glennc added this to the 1.0.0-beta8 milestone Aug 7, 2015
rynowak added a commit that referenced this issue Aug 19, 2015
@rynowak
Fix #365 - Make IFormFileCollection implmenent IReadOnlyList<T>
54b90ba
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rynowak rynowak

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Eilon @glennc @rynowak @Tratcher