Add AuthenticationProperties to AuthenticateResult for failures.

Author: Tratcher

src/Microsoft.AspNetCore.Authentication.Abstractions/AuthenticateResult.cs

@@ -31,12 +31,17 @@ protected AuthenticateResult() { }
         /// <summary>
         /// Additional state values for the authentication session.
         /// </summary>
-        public AuthenticationProperties Properties => Ticket?.Properties;
+        public AuthenticationProperties Properties => Ticket?.Properties ?? Error?.Properties;
 
         /// <summary>
         /// Holds failure information from the authentication.
         /// </summary>
-        public Exception Failure { get; protected set; }
+        public Exception Failure => Error?.Failure;
+
+        /// <summary>
+        /// Holds error information from the authentication.
+        /// </summary>
+        public AuthenticationError Error { get; protected set; }
 
         /// <summary>
         /// Indicates that there was no information returned for this authentication scheme.
@@ -73,17 +78,35 @@ public static AuthenticateResult NoResult()
         /// <returns>The result.</returns>
         public static AuthenticateResult Fail(Exception failure)
         {
-            return new AuthenticateResult() { Failure = failure };
+            return new AuthenticateResult() { Error = new AuthenticationError(failure) };
         }
 
         /// <summary>
         /// Indicates that there was a failure during authentication.
         /// </summary>
-        /// <param name="failureMessage">The failure message.</param>
+        /// <param name="failure">The failure exception.</param>
+        /// <param name="properties">Additional state values for the authentication session.</param>
         /// <returns>The result.</returns>
-        public static AuthenticateResult Fail(string failureMessage)
+        public static AuthenticateResult Fail(Exception failure, AuthenticationProperties properties)
         {
-            return new AuthenticateResult() { Failure = new Exception(failureMessage) };
+            return new AuthenticateResult() { Error = new AuthenticationError(failure, properties) };
         }
+
+        /// <summary>
+        /// Indicates that there was a failure during authentication.
+        /// </summary>
+        /// <param name="failureMessage">The failure message.</param>
+        /// <returns>The result.</returns>
+        public static AuthenticateResult Fail(string failureMessage)
+            => Fail(new Exception(failureMessage));
+
+        /// <summary>
+        /// Indicates that there was a failure during authentication.
+        /// </summary>
+        /// <param name="failureMessage">The failure message.</param>
+        /// <param name="properties">Additional state values for the authentication session.</param>
+        /// <returns>The result.</returns>
+        public static AuthenticateResult Fail(string failureMessage, AuthenticationProperties properties)
+            => Fail(new Exception(failureMessage), properties);
     }
 }

src/Microsoft.AspNetCore.Authentication.Abstractions/AuthenticationError.cs

@@ -0,0 +1,31 @@
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+using System;
+
+namespace Microsoft.AspNetCore.Authentication
+{
+    public class AuthenticationError
+    {
+        public AuthenticationError(Exception failure)
+        {
+            Failure = failure ?? throw new ArgumentNullException(nameof(failure));
+        }
+
+        public AuthenticationError(Exception failure, AuthenticationProperties properties)
+            : this(failure)
+        {
+            Properties = properties;
+        }
+
+        /// <summary>
+        /// Holds failure information from the authentication.
+        /// </summary>
+        public Exception Failure { get; }
+
+        /// <summary>
+        /// Additional state values for the authentication session.
+        /// </summary>
+        public AuthenticationProperties Properties { get; }
+    }
+}