This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Rename environment variables to ASPNETCORE_. #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tratcher - do you still support the old variables? ie. will we be broken when we pick up this change? |
|
Yes you'll be broken. Make sure you write an announcement |
|
Correct, we're not supporting the old variables this time. |
|
|
|
@Tratcher Announcement issue? |
|
Could you please also update and/or add a comment to aspnet/Announcements#108 which contains the table with all new names. |
|
Commented. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the legacy ENV abbreviation.
@DamianEdwards @davidfowl @muratg @JunTaoLuo @BillHiebert