This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Attempts to fix urls from appsettings.json, CLI #1298
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebHost checks _config for the deprecated "server.urls" key but it also checks _config for the new key . I believe it should use _startup.Configure for the new key. The ultimate problem I'm trying to solve is that:
WebHost.CreateDefaultBuilder(args)
.UseStartup<Startup>()
.Build();
...doesn't read the urls from appsettings.json or the command line.
I haven't tested this change--I'm editing via the GitHub web interface.
muratg
reviewed
Dec 20, 2017
|
This code doesn't compile. _startup.Configure is a method, not an IConfiguration instance. I'm closing this and we can discuss it issue over at #1299. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebHost checks _config for the deprecated "server.urls" key but it also checks _config for the new key . I believe it should use _startup.Configure for the new key. The ultimate problem I'm trying to solve is that:
WebHost.CreateDefaultBuilder(args)
.UseStartup()
.Build();
...doesn't read the urls from appsettings.json or the command line. The builder pushes the values into the Startup constructor so they should be available via Startup.Configure.
I haven't tested this change--I'm editing via the GitHub web interface.