Obsolete RepositoryRoot property, replace with RepoRoot #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One merged, I will open a PR to aspnet/AspNetCore to complete the rename. |
dougbu
approved these changes
May 15, 2019
| <ArtifactsDir>$([MSBuild]::NormalizeDirectory('$(RepositoryRoot)'))artifacts\</ArtifactsDir> | ||
| <RepoRoot Condition="'$(RepoRoot)' == ''">$(MSBuildStartupDirectory)</RepoRoot> | ||
| <RepoRoot>$([MSBuild]::NormalizeDirectory('$(RepoRoot)'))</RepoRoot> | ||
| <!-- Older targets using KoreBuild use RepositoryRoot. Update to use RepoRoot whenever possible as a part of migrating to Arcade. --> |
There was a problem hiding this comment.
"Older targets" where exactly? In this repo still or in aspnet/AspNetCore for a very short time?
Suggest adding some more info to this comment unless the older targets won't exist in a couple of days.
There was a problem hiding this comment.
This project is still open source so anyone could be using KoreBuild. At least a few teams at Microsoft are still using KoreBuild and I don't want to completely break them. Eventually we will completely retire KoreBuild because we only care about supporting the AspNetCore repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of dotnet/aspnetcore#7280 - Arcade uses RepoRoot, not RepositoryRoot, to mean the same thing. This upgrades code to use RepoRoot. RepositoryRoot is still defined to the same value for any old targets or repos still using this property.