Skip to content

Respond to latest SlimBuilder changes in BasicGrpc #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

eerhardt
Copy link
Contributor

  • Add appsettings
  • Clear logging providers
  • Add launchSettings

The BasicGrpc RPS took a dive due to console logging getting enabled.

image

- Add appsettings
- Clear logging providers
- Add launchSettings
@DamianEdwards
Copy link
Member

We really need to fix that logger provider lock

@JamesNK JamesNK merged commit 8d7808c into aspnet:main Apr 28, 2023
@eerhardt eerhardt deleted the FixGrpc branch April 28, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants