This repository was archived by the owner on Jun 20, 2019. It is now read-only.
Fix websocket close handshake issue and race condition when websocket… #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… client disconnect without close handshake
jkotalik
reviewed
Sep 11, 2017
| @@ -376,6 +376,7 @@ ASPNETCORE_CONFIG::Populate( | |||
| strExpandedEnvValue.Reset(); | |||
| pEnvVar->Release(); | |||
| pEnvVar = NULL; | |||
| pEntry->Dereference(); | |||
There was a problem hiding this comment.
Is this related to the fix or is it unrelated.
There was a problem hiding this comment.
this fixes a memory leak
|
thanks |
|
So, when this bugfix will be released as a part of new version of nuget package for websockets? |
|
@risogolo the bugfix is not in the websocket nuget package, it's in the AspNetCoreModule which installs via MSI. Expect the MSI with 2.1.0-preview. |
|
but this bug is also in 1.x |
|
ANCM does not version like packages, it's an in place update. The next MSI released will affect all versions of ASP.NET Core. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… client disconnect without close handshake #77