Skip to content
This repository was archived by the owner on Jun 20, 2019. It is now read-only.

[AspNetCoreModule] Use HttpResponse.PushPromise #28

Closed
Tratcher opened this issue Oct 27, 2016 · 3 comments
Closed

[AspNetCoreModule] Use HttpResponse.PushPromise #28

Tratcher opened this issue Oct 27, 2016 · 3 comments

Comments

@Tratcher
Copy link
Member

From @benaadams on May 1, 2016 11:37

To more fully utilize http/2 where available, if response includes Link header with a local path and rel of preload add PushPromise for that path.

This will enable the reverse-proxy (IIS) to "value add" more http/2 features to Kestrel when used in that configuration. (e.g. Win10, Server 2016, nano server)

e.g.

Link: /css/site.css; rel=preload;

Add

HttpResponse.PushPromise("/css/site.css");

Or

Link:  /css/site.css; rel=preload; as=style;,/fonts/font1.woff; rel=preload; as=font;,/fonts/font2.woff; rel=preload; as=font;

Add

HttpResponse.PushPromise("/css/site.css");
HttpResponse.PushPromise("/fonts/font1.woff");
HttpResponse.PushPromise("/fonts/font2.woff");

IIS PushPromise as per http://blogs.iis.net/davidso/http2

Link header parsing to add push promises as per https://blog.cloudflare.com/announcing-support-for-http-2-server-push-2/

/cc @DamianEdwards

Copied from original issue: aspnet/IISIntegration#160

@Tratcher
Copy link
Member Author

From @dopare on May 1, 2016 14:43

Really must have feature.

Thanks @benaadams

@Tratcher
Copy link
Member Author

RE: aspnet/HttpAbstractions#371

@muratg
Copy link
Contributor

muratg commented Dec 20, 2017

Closing this for now. We'll re-open in case we decide to implement push promise in ASP.NET Core stack.

@muratg muratg closed this as completed Dec 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants