Use lambda_http 0.5 instead of fork #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslamplr
approved these changes
Apr 20, 2022
| @@ -5,11 +5,11 @@ use warp::Filter; | |||
| async fn main() -> Result<()> { | |||
| // Your warp routes (filters) | |||
| let routes = warp::any().map(|| "Hello, World!"); | |||
| // Convert them to a warp service (a tower service implmentation) | |||
| // Convert them to a warp service (a tower service implementation) | |||
| // using `warp::service()` | ||
| let warp_service = warp::service(routes); | ||
| // The warp_lambda::run() function takes care of invoking the aws lambda runtime for you | ||
| warp_lambda::run(warp_service) | ||
| .await | ||
| .map_err(|err| anyhow!("An error occured `{:#?}`", err)) | ||
| .map_err(|err| anyhow!("An error occurred `{:#?}`", err)) |
| @@ -2,50 +2,66 @@ use core::future::Future; | |||
| use std::convert::Infallible; | |||
| use std::pin::Pin; | |||
|
|
|||
| pub use lamedh_http as lambda_http; | |||
There was a problem hiding this comment.
Finally, we are able to get rid of this!
| } | ||
|
|
||
| fn call(&mut self, req: Request) -> Self::Future { | ||
| let query_params = req.query_string_parameters(); |
|
Resolved ✅ Error message when compiling: `error[E0599]: no method named `ready` found for type parameter `F` in the current scope``cargo check` and `cargo build` fails in local (Rust version `1.60.0`) Detailed Error
Resolution: remove |
|
Merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the official lambda_http release 0.5 which fixes awslabs/aws-lambda-rust-runtime#274 and updates the warp adapter to implement
tower::Servicedirectly now that the lambda http handler has been removed.