Merge pull request lightspeed-core#712 from radofuchs/fix_constant_hostname

fix constant hostname in e2e tests

Author: radofuchs

tests/e2e/features/authorized_noop.feature

@@ -2,8 +2,6 @@ Feature: Authorized endpoint API tests for the noop authentication module
 
   Background:
     Given The service is started locally
-      And REST API service hostname is localhost
-      And REST API service port is 8080
       And REST API service prefix is /v1
 
   Scenario: Check if the authorized endpoint works fine when user_id and auth header are not provided 

tests/e2e/features/authorized_noop_token.feature

@@ -3,8 +3,6 @@ Feature: Authorized endpoint API tests for the noop-with-token authentication mo
 
   Background:
     Given The service is started locally
-      And REST API service hostname is localhost
-      And REST API service port is 8080
       And REST API service prefix is /v1
 
   Scenario: Check if the authorized endpoint fails when user_id and auth header are not provided 

tests/e2e/features/conversations.feature

@@ -3,8 +3,6 @@ Feature: conversations endpoint API tests
 
   Background:
     Given The service is started locally
-      And REST API service hostname is localhost
-      And REST API service port is 8080
       And REST API service prefix is /v1
 
 

tests/e2e/features/environment.py

@@ -10,6 +10,7 @@
 import requests
 import subprocess
 import time
+import os
 from behave.model import Scenario, Feature
 from behave.runner import Context
 
@@ -21,14 +22,16 @@
 )
 
 
-def _fetch_models_from_service(hostname: str = "localhost", port: int = 8080) -> dict:
+def _fetch_models_from_service() -> dict:
     """Query /v1/models endpoint and return first LLM model.
 
     Returns:
         Dict with model_id and provider_id, or empty dict if unavailable
     """
     try:
-        url = f"http://{hostname}:{port}/v1/models"
+        host_env = os.getenv("E2E_LSC_HOSTNAME", "localhost")
+        port_env = os.getenv("E2E_LSC_PORT", "8080")
+        url = f"http://{host_env}:{port_env}/v1/models"
         response = requests.get(url, timeout=5)
         response.raise_for_status()
         data = response.json()
@@ -105,7 +108,7 @@ def after_scenario(context: Context, scenario: Scenario) -> None:
                             "llama-stack",
                             "curl",
                             "-f",
-                            "http://localhost:8321/v1/health",
+                            f"http://{context.hostname_llama}:{context.port_llama}/v1/health",
                         ],
                         capture_output=True,
                         timeout=5,
@@ -155,7 +158,7 @@ def after_feature(context: Context, feature: Feature) -> None:
     if "Feedback" in feature.tags:
         print(context.feedback_conversations)
         for conversation_id in context.feedback_conversations:
-            url = f"http://localhost:8080/v1/conversations/{conversation_id}"
+            url = f"http://{context.hostname}:{context.port}/v1/conversations/{conversation_id}"
             headers = context.auth_headers if hasattr(context, "auth_headers") else {}
             response = requests.delete(url, headers=headers)
             assert response.status_code == 200, url

tests/e2e/features/feedback.feature

@@ -4,8 +4,6 @@ Feature: feedback endpoint API tests
 
   Background:
     Given The service is started locally
-      And REST API service hostname is localhost
-      And REST API service port is 8080
       And REST API service prefix is /v1
       And I set the Authorization header to Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6Ikpva
 

tests/e2e/features/health.feature

@@ -3,8 +3,6 @@ Feature: REST API tests
 
   Background:
     Given The service is started locally
-      And REST API service hostname is localhost
-      And REST API service port is 8080
       And REST API service prefix is /v1
 
 

tests/e2e/features/info.feature

@@ -3,8 +3,6 @@ Feature: Info tests
 
   Background:
     Given The service is started locally
-      And REST API service hostname is localhost
-      And REST API service port is 8080
       And REST API service prefix is /v1
 
   Scenario: Check if the OpenAPI endpoint works as expected

tests/e2e/features/query.feature

@@ -3,8 +3,6 @@ Feature: Query endpoint API tests
 
   Background:
     Given The service is started locally
-      And REST API service hostname is localhost
-      And REST API service port is 8080
       And REST API service prefix is /v1
 
   Scenario: Check if LLM responds properly to restrictive system prompt to sent question with different system prompt

tests/e2e/features/rest_api.feature

@@ -3,8 +3,6 @@ Feature: REST API tests
 
   Background:
     Given The service is started locally
-      And REST API service hostname is localhost
-      And REST API service port is 8080
       And REST API service prefix is /v1
 
   Scenario: Check if the OpenAPI endpoint works as expected

tests/e2e/features/smoketests.feature

@@ -3,8 +3,6 @@ Feature: Smoke tests
 
   Background:
     Given The service is started locally
-      And REST API service hostname is localhost
-      And REST API service port is 8080
       And REST API service prefix is /v1