Skip to content

Commit ab9923b

Browse files
Bump io.grpc:grpc-bom from 1.73.0 to 1.74.0 in /protobuf-maven-plugin/src/it/setup (#754)
1 parent 3791a4d commit ab9923b

File tree

8 files changed

+24
-20
lines changed

8 files changed

+24
-20
lines changed

protobuf-maven-plugin/src/it/gh-277-plugin-ordering/pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,6 @@
8787
<groupId>io.grpc</groupId>
8888
<artifactId>protoc-gen-grpc-java</artifactId>
8989
<version>${grpc.version}</version>
90-
<!-- See https://github.com/grpc/grpc-java/issues/9179 -->
91-
<options>@generated=omit</options>
9290
<order>100</order>
9391
</binaryMavenPlugin>
9492
</binaryMavenPlugins>

protobuf-maven-plugin/src/it/grpc-plugin/pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@
8585
<groupId>io.grpc</groupId>
8686
<artifactId>protoc-gen-grpc-java</artifactId>
8787
<version>${grpc.version}</version>
88-
<!-- See https://github.com/grpc/grpc-java/issues/9179 -->
89-
<options>@generated=omit</options>
9088
</binaryMavenPlugin>
9189
</binaryMavenPlugins>
9290
</configuration>

protobuf-maven-plugin/src/it/http-url-grpc-plugin/pom.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,8 @@
9090
<binaryUrlPlugin>
9191
<url>https://repo1.maven.org/maven2/io/grpc/protoc-gen-grpc-java/${grpc.version}/protoc-gen-grpc-java-${grpc.version}-linux-x86_64.exe</url>
9292
<digest>sha256:a9f9a7987be4a37c69a85e5e8885394356fd2f1a47f843c6461da4fc99f407b3</digest>
93-
<!-- See https://github.com/grpc/grpc-java/issues/9179 -->
93+
<!-- Needed until we use gRPC 1.74.0 or newer, as this avoids the dependency on
94+
javax.annotation-api. -->
9495
<options>@generated=omit</options>
9596
</binaryUrlPlugin>
9697
</binaryUrlPlugins>

protobuf-maven-plugin/src/it/per-plugin-output-paths/pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,6 @@
9191
<groupId>io.grpc</groupId>
9292
<artifactId>protoc-gen-grpc-java</artifactId>
9393
<version>${grpc.version}</version>
94-
<!-- See https://github.com/grpc/grpc-java/issues/9179 -->
95-
<options>@generated=omit</options>
9694
<outputDirectory>${project.basedir}/target/generated-sources/grpc</outputDirectory>
9795
</binaryMavenPlugin>
9896

protobuf-maven-plugin/src/it/reactor-grpc-binary-plugin/pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,6 @@
9191
<groupId>io.grpc</groupId>
9292
<artifactId>protoc-gen-grpc-java</artifactId>
9393
<version>${grpc.version}</version>
94-
<!-- See https://github.com/grpc/grpc-java/issues/9179 -->
95-
<options>@generated=omit</options>
9694
</binaryMavenPlugin>
9795

9896
<binaryMavenPlugin>

protobuf-maven-plugin/src/it/setup/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<packaging>pom</packaging>
3434

3535
<properties>
36-
<grpc.version>1.73.0</grpc.version>
36+
<grpc.version>1.74.0</grpc.version>
3737
<kotlin.version>2.2.0</kotlin.version>
3838
<proto-google-common-protos.version>2.59.2</proto-google-common-protos.version>
3939
<scala.version>3.7.2</scala.version>

protobuf-maven-plugin/src/site/markdown/examples.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,19 @@ For generating gRPC stubs for Java, you can use the official gRPC Java plugin:
2121
<groupId>io.grpc</groupId>
2222
<artifactId>protoc-gen-grpc-java</artifactId>
2323
<version>${grpc.version}</version>
24-
<!-- Avoid dependency on javax.annotation-api -->
25-
<options>@generated=omit</options>
2624
</binaryMavenPlugin>
2725
</binaryMavenPlugins>
2826
</configuration>
2927
</plugin>
3028
```
3129

30+
Note that for gRPC versions prior to 1.74.0, you should also pass the following options
31+
to avoid dependencies on `javax.annotation-api`.
32+
33+
```xml
34+
<options>@generated=omit</options>
35+
```
36+
3237
## JavaScript and gRPC-Web
3338

3439
While JavaScript generation is not natively supported by this plugin (as it's not part of core protoc), you can easily integrate JavaScript and gRPC-Web code generation using binary URL plugins.

protobuf-maven-plugin/src/site/markdown/using-protoc-plugins.md

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ that plugin directly via the group ID, artifact ID, and version (like any other
4848
<groupId>io.grpc</groupId>
4949
<artifactId>protoc-gen-grpc-java</artifactId>
5050
<version>${grpc.version}</version>
51-
<!-- Avoid dependency on javax.annotation-api -->
52-
<options>@generated=omit</options>
5351
</binaryMavenPlugin>
5452
</binaryMavenPlugins>
5553
</configuration>
@@ -58,6 +56,13 @@ that plugin directly via the group ID, artifact ID, and version (like any other
5856
</plugin>
5957
```
6058

59+
Note that for gRPC versions prior to 1.74.0, you should also pass the following options
60+
to avoid dependencies on `javax.annotation-api`.
61+
62+
```xml
63+
<options>@generated=omit</options>
64+
```
65+
6166
### Binary plugins from the system path
6267

6368
If you instead wish to read the executable from the system `$PATH`, then you can specify an
@@ -74,8 +79,6 @@ executable name instead:
7479
<binaryPathPlugins>
7580
<binaryPathPlugin>
7681
<name>protoc-gen-grpc-java</name>
77-
<!-- Avoid dependency on javax.annotation-api -->
78-
<options>@generated=omit</options>
7982
</binaryPathPlugin>
8083
</binaryPathPlugins>
8184
</configuration>
@@ -84,6 +87,13 @@ executable name instead:
8487
</plugin>
8588
```
8689

90+
Note that for gRPC versions prior to 1.74.0, you should also pass the following options
91+
to avoid dependencies on `javax.annotation-api`.
92+
93+
```xml
94+
<options>@generated=omit</options>
95+
```
96+
8797
You can also mark these plugins as being optional by setting `<optional>true</optional>` on the
8898
individual plugin objects. This will prevent the Maven plugin from failing the build if the `protoc` plugin
8999
cannot be resolved on the system path. This is useful for specific cases where resources may only be available
@@ -115,8 +125,6 @@ specific file system path:
115125
<binaryUrlPlugins>
116126
<binaryUrlPlugin>
117127
<url>file:///opt/protoc/protoc-gen-grpc-java</url>
118-
<!-- Avoid dependency on javax.annotation-api -->
119-
<options>@generated=omit</options>
120128
</binaryUrlPlugin>
121129
<binaryUrlPlugin>
122130
<url>ftp://company-server.internal/some-other-plugin.exe</url>
@@ -274,8 +282,6 @@ then you can provide the following:
274282
<groupId>io.grpc</groupId>
275283
<artifactId>protoc-gen-grpc-java</artifactId>
276284
<version>${grpc.version}</version>
277-
<!-- Avoid dependency on javax.annotation-api -->
278-
<options>@generated=omit</options>
279285
</binaryMavenPlugin>
280286
</binaryMavenPlugins>
281287
<jvmMavenPlugins>

0 commit comments

Comments
 (0)