Remove outdated action version specification from comments #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow is using v3 now, and there has not been any on the permissions situation documented by this comment: https://github.com/actions/upload-artifact/tree/v3#permission-loss Since we have gotten behind on this comment at each bump and there is no sign that they will ever change the behavior (and also no reason to believe that it would align with a major version bump even if they did), I think it is best to just remove the version specification from the comment altogether.
per1234
added
type: imperfection
umbynos
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow is using v3 now, and there has not been any on the permissions situation documented by this comment:
https://github.com/actions/upload-artifact/tree/v3#permission-loss
Since we have gotten behind on this comment at each bump and there is no sign that they will ever change the behavior (and also no reason to believe that it would align with a major version bump even if they did), I think it is best to just remove the version specification from the comment altogether.