Update comment #91
Update comment #91
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 752 776 +24
=========================================
+ Hits 752 776 +24 ☔ View full report in Codecov by Sentry. |
2bndy5
force-pushed
the
update-comment
branch
2 times, most recently
from
6364a8c to
78a9da8
Compare
|
ping @per1234 |
2bndy5
force-pushed
the
update-comment
branch
from
83e1dc3 to
6624ff5
Compare
|
I've been keeping my fork in sync with upstream. I've also been using these changes for all nRF24 org repos (since I opened this PR), and I haven't seen any unexpected behavior so far. Not sure what I need to do to get this reviewed (by admins). It's been idling for over half a year. This repo hasn't been getting much attention lately 😞 . |
per1234
added
type: enhancement
If no comment exists, then simply post a new comment. If more than 1 comment found, then delete all but last one and update the last one.
distutils has been deprecated for years; use shutil instead add unit test for `get_previous_comment()`
defaults to false for old behavior
update tests accordingly replaces `get_previous_comment()` which was almost identical to `report_exists()`
|
I removed the change about required python version. I was able to setup a local venv with python v3.11 using @per1234 Please review this. I've been rebasing my branch for over a year. |
avoids treating user comments as a bot comment
resolves #90
Goals
What does it do?
update-commentthat defaults tofalse(for current behavior)update-commentis set totrue, the first report comment found is updated. Furthermore, if other report comments are found in the same thread, they will be deleted.<!-- arduino/report-size-deltas -->) to distinguish bot comments from any user comment that also starts with**Memory usage change @. This means no user comments will be accidentally deleted or updated.Other changes
I prefer to use a local venv for developing on python-based projects. So, I had to add some typical names used for a local venv located at repo root to
.gitignore,.flake8, and.prettierignore.I have made sure that all unit tests still pass and added one unit test for the new functionality.