Handle root submission URLs #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a submission URL with a root path resulted in a panic: panic: Rel: can't make .git relative to / These URLs won't represent a valid submission, but panics should only occur when the error should not occur under any normal circumstances. By avoiding the panic, the process will fail with the helpful error either that the URL is not under a supported Git host (e.g., https://mycoollibrary.com as submission), or that it is not a valid Git clone URL (e.g., https://github.com as submission).
per1234
added
type: imperfection
silvanocerza
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a submission URL with a root path resulted in a panic:
These URLs won't represent a valid submission, but panics should only occur when the error should not occur under any normal circumstances. By avoiding the panic, the process will fail with the helpful error either that the URL is not under a supported Git host (e.g.,
https://mycoollibrary.comas submission), or that it is not a valid Git clone URL (e.g.,https://git.colasdn.topas submission).