Skip to content

Commit cc02eee

Browse files
committed
Add better validation for datasheets
1 parent 0bcae7b commit cc02eee

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

scripts/validation/config/config-generic.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,7 @@ validateMetadata: true
1919
verbose: true
2020

2121
# Allows to debug the rules by outputting process messages
22-
debug: false
22+
debug: false
23+
24+
# Defines rules for what links not to check. Usually relative links should not be checked.
25+
brokenLinkExcludePatterns: [^./, ^../, ^#, ^chrome://, localhost , ^assets/, ^images/]

scripts/validation/config/config-tutorials.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,3 @@ validationRuleFiles: [./rules/rules-spelling.yml, ./rules/rules-trademarks.yml,
1010
allowNestedLists: false
1111
metadataSchema: rules/tutorial-metadata-schema.json
1212

13-
brokenLinkExcludePatterns: [^./, ^../, ^#, ^chrome://, localhost , ^assets/, ^images/]

scripts/validation/validate.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@ if(!allArticles || allArticles.length == 0){
3030
// Verify that all meta data is valid JSON and contains the correct attributes
3131
if(configManager.getConfig("generic").validateMetadata){
3232
validator.addValidation(tutorials, validateMetaData, configManager.getConfig("tutorials").metadataSchema);
33-
}
34-
35-
if(configManager.getConfig("generic").validateMetadata){
3633
validator.addValidation(datasheets, validateMetaData, configManager.getConfig("datasheets").metadataSchema);
3734
}
3835

@@ -56,7 +53,7 @@ validator.addValidation(allArticles, validateSVGFiles);
5653

5754
// Verify that there are no broken links
5855
if(configManager.options.checkBrokenLinks){
59-
validator.addValidation(tutorials, validateBrokenLinks, configManager.getConfig("tutorials").brokenLinkExcludePatterns, configManager.getConfig("generic").baseURL, configManager.options.verbose);
56+
validator.addValidation(allArticles, validateBrokenLinks, configManager.getConfig("generic").brokenLinkExcludePatterns, configManager.getConfig("generic").baseURL, configManager.options.verbose);
6057
};
6158

6259
// Verify that all files in the assets folder are referenced

0 commit comments

Comments
 (0)