Declare and assign variable separately in setup script #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage of `readonly` was added to ShellCheck rule SC2155: https://github.com/koalaman/shellcheck/wiki/SC2155#problematic-code-in-the-case-of-readonly > ### Problematic code in the case of `readonly`: > > ```sh > readonly foo="$(mycmd)" > ``` > > #### Correct code: > > ```sh > foo="$(mycmd)" > readonly foo > ``` There was this sort of "problematic code" in the action setup script, which caused the "Lint shell scripts" CI workflow to start failing after the 0.7.2 release of ShellCheck. The script's usage of `readonly` is now adjusted according to ShellCheck's recommendation.
per1234
added
type: imperfection
umbynos
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage of
readonlywas added (koalaman/shellcheck#2077) to ShellCheck rule SC2155:https://github.com/koalaman/shellcheck/wiki/SC2155#problematic-code-in-the-case-of-readonly
There is this sort of "problematic code" in the action setup script, which caused the "Lint shell scripts" CI workflow to start
failing after the 0.7.2 release of ShellCheck:
https://github.com/arduino/compile-sketches/actions/workflows/lint-shell.yml
The script's usage of
readonlyis now adjusted according to ShellCheck's recommendation.