Use JSON pointer as package component ID when standard ID component empty #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpty In cases where the data used to assemble the standard ID used to refer to a package component is undefined, the JSON pointer is used. Previously, when the data is defined, but empty, the standard ID format was used. But this will not be very meaningful. In this case, the JSON pointer will serve as a more useful ID.
Codecov Report
@@ Coverage Diff @@
## main #192 +/- ##
==========================================
+ Coverage 84.22% 84.25% +0.02%
==========================================
Files 43 43
Lines 3202 3207 +5
==========================================
+ Hits 2697 2702 +5
Misses 393 393
Partials 112 112
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
silvanocerza
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the data used to assemble the standard ID used to refer to a package component is undefined, the JSON
pointer is used.
Previously, when the data is defined, but empty, the standard ID format was used. But this will not be very meaningful.
In this case, the JSON pointer will serve as a more useful ID.