Skip to content

Update go-lsp to 0.1.2 #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Update go-lsp to 0.1.2 #150

merged 1 commit into from
Jan 11, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jan 11, 2023

Please check if the PR fulfills these requirements

What kind of change does this PR introduce?
Fix other LSP DocumentURI encodings problems.

What is the current behavior?

What is the new behavior?

Other information:
See bugst/go-lsp#2

@cmaglie cmaglie self-assigned this Jan 11, 2023
@cmaglie cmaglie requested a review from kittaakos January 11, 2023 15:17
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes solve the issue for arduino/arduino-ide#1124 on Windows. Thank you!

1124_win.mp4

@cmaglie cmaglie merged commit d620b0b into main Jan 11, 2023
@cmaglie cmaglie deleted the update-go-lsp branch January 11, 2023 15:39
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants