Handle rename symbol

Author: cmaglie

go.mod

@@ -9,6 +9,6 @@ require (
 	github.com/pkg/errors v0.9.1
 	github.com/stretchr/testify v1.7.0
 	go.bug.st/json v1.15.6
-	go.bug.st/lsp v0.0.0-20211130152916-c597b0a0439f
+	go.bug.st/lsp v0.0.0-20211202163946-3ad3994172a0
 	google.golang.org/grpc v1.42.0
 )

go.sum

@@ -339,6 +339,8 @@ go.bug.st/json v1.15.6 h1:pvSpotu6f5JoCbx1TnKn6asVH7o9Tg2/GKsZSVzBOsc=
 go.bug.st/json v1.15.6/go.mod h1:bh58F9adz5ePlNqtvbuXuXcf9k6IrDLKH6lJUsHP3TI=
 go.bug.st/lsp v0.0.0-20211130152916-c597b0a0439f h1:Rj7FdBdROWh9mMra/16G/5d7u/QE0Wwq487NZt+Evjg=
 go.bug.st/lsp v0.0.0-20211130152916-c597b0a0439f/go.mod h1:oYTh1uf5hI1teV5crrWut41Pk8vD/NqIjs4zD+No5FE=
+go.bug.st/lsp v0.0.0-20211202163946-3ad3994172a0 h1:/SnZ7aZ3bmfUKWbhckiK6L4mv9vyf9HgwV6X0dm+/is=
+go.bug.st/lsp v0.0.0-20211202163946-3ad3994172a0/go.mod h1:oYTh1uf5hI1teV5crrWut41Pk8vD/NqIjs4zD+No5FE=
 go.bug.st/relaxed-semver v0.0.0-20190922224835-391e10178d18 h1:F1qxtaFuewctYc/SsHRn+Q7Dtwi+yJGPgVq8YLtQz98=
 go.bug.st/relaxed-semver v0.0.0-20190922224835-391e10178d18/go.mod h1:Cx1VqMtEhE9pIkEyUj3LVVVPkv89dgW8aCKrRPDR/uE=
 go.bug.st/serial v1.3.2/go.mod h1:jDkjqASf/qSjmaOxHSHljwUQ6eHo/ZX/bxJLQqSlvZg=

ls/ls.go

@@ -371,14 +371,14 @@ func (ls *INOLanguageServer) TextDocumentCompletionReqFromIDE(ctx context.Contex
 	ls.readLock(logger, true)
 	defer ls.readUnlock(logger)
 
-	cppTextDocPositionParams, err := ls.ide2ClangTextDocumentPositionParams(logger, ideParams.TextDocumentPositionParams)
+	clangTextDocPositionParams, err := ls.ide2ClangTextDocumentPositionParams(logger, ideParams.TextDocumentPositionParams)
 	if err != nil {
 		logger.Logf("Error: %s", err)
 		return nil, &jsonrpc.ResponseError{Code: jsonrpc.ErrorCodesInternalError, Message: err.Error()}
 	}
 
 	clangParams := &lsp.CompletionParams{
-		TextDocumentPositionParams: cppTextDocPositionParams,
+		TextDocumentPositionParams: clangTextDocPositionParams,
 		Context:                    ideParams.Context,
 		WorkDoneProgressParams:     ideParams.WorkDoneProgressParams,
 		PartialResultParams:        ideParams.PartialResultParams,
@@ -637,14 +637,14 @@ func (ls *INOLanguageServer) TextDocumentImplementationReqFromIDE(ctx context.Co
 	ls.readLock(logger, true)
 	defer ls.readUnlock(logger)
 
-	cppTextDocumentPosition, err := ls.ide2ClangTextDocumentPositionParams(logger, ideParams.TextDocumentPositionParams)
+	clangTextDocumentPosition, err := ls.ide2ClangTextDocumentPositionParams(logger, ideParams.TextDocumentPositionParams)
 	if err != nil {
 		logger.Logf("Error: %s", err)
 		return nil, nil, &jsonrpc.ResponseError{Code: jsonrpc.ErrorCodesInternalError, Message: err.Error()}
 	}
 
 	clangParams := &lsp.ImplementationParams{
-		TextDocumentPositionParams: cppTextDocumentPosition,
+		TextDocumentPositionParams: clangTextDocumentPosition,
 		WorkDoneProgressParams:     ideParams.WorkDoneProgressParams,
 		PartialResultParams:        ideParams.PartialResultParams,
 	}
@@ -1212,6 +1212,40 @@ func (ls *INOLanguageServer) PublishDiagnosticsNotifFromClangd(logger jsonrpc.Fu
 	}
 }
 
+func (ls *INOLanguageServer) TextDocumentRenameReqFromIDE(ctx context.Context, logger jsonrpc.FunctionLogger, ideParams *lsp.RenameParams) (*lsp.WorkspaceEdit, *jsonrpc.ResponseError) {
+	ls.writeLock(logger, false)
+	defer ls.writeUnlock(logger)
+
+	clangTextDocPositionParams, err := ls.ide2ClangTextDocumentPositionParams(logger, ideParams.TextDocumentPositionParams)
+	if err != nil {
+		logger.Logf("Error: %s", err)
+		return nil, &jsonrpc.ResponseError{Code: jsonrpc.ErrorCodesInternalError, Message: err.Error()}
+	}
+
+	clangParams := &lsp.RenameParams{
+		TextDocumentPositionParams: clangTextDocPositionParams,
+		NewName:                    ideParams.NewName,
+		WorkDoneProgressParams:     ideParams.WorkDoneProgressParams,
+	}
+	clangWorkspaceEdit, clangErr, err := ls.Clangd.conn.TextDocumentRename(ctx, clangParams)
+	if err != nil {
+		logger.Logf("clangd communication error: %v", err)
+		ls.Close()
+		return nil, &jsonrpc.ResponseError{Code: jsonrpc.ErrorCodesInternalError, Message: err.Error()}
+	}
+	if clangErr != nil {
+		logger.Logf("clangd response error: %v", clangErr.AsError())
+		return nil, &jsonrpc.ResponseError{Code: jsonrpc.ErrorCodesInternalError, Message: clangErr.AsError().Error()}
+	}
+
+	ideWorkspaceEdit, err := ls.clang2IdeWorkspaceEdit(logger, clangWorkspaceEdit)
+	if err != nil {
+		logger.Logf("Error: %s", err)
+		return nil, &jsonrpc.ResponseError{Code: jsonrpc.ErrorCodesInternalError, Message: err.Error()}
+	}
+	return ideWorkspaceEdit, nil
+}
+
 func (ls *INOLanguageServer) ProgressNotifFromClangd(logger jsonrpc.FunctionLogger, progress *lsp.ProgressParams) {
 	var token string
 	if err := json.Unmarshal(progress.Token, &token); err != nil {

ls/ls_clang_to_ide.go

@@ -12,6 +12,11 @@ func (ls *INOLanguageServer) clangURIRefersToIno(clangURI lsp.DocumentURI) bool
 	return clangURI.AsPath().EquivalentTo(ls.buildSketchCpp)
 }
 
+// Convert Range and DocumentURI from Clang to IDE.
+// Returns:
+// - The IDE DocumentURI and Range
+// - a boolean that is true if the clang range is in the preprocessed area of the sketch
+// - an error
 func (ls *INOLanguageServer) clang2IdeRangeAndDocumentURI(logger jsonrpc.FunctionLogger, clangURI lsp.DocumentURI, clangRange lsp.Range) (lsp.DocumentURI, lsp.Range, bool, error) {
 	// Sketchbook/Sketch/Sketch.ino      <-> build-path/sketch/Sketch.ino.cpp
 	// Sketchbook/Sketch/AnotherTab.ino  <-> build-path/sketch/Sketch.ino.cpp  (different section from above)
@@ -308,3 +313,34 @@ func (ls *INOLanguageServer) clang2IdeSymbolsInformation(logger jsonrpc.Function
 	logger.Logf("SymbolInformation (%d elements):", len(clangSymbolsInformation))
 	panic("not implemented")
 }
+
+func (ls *INOLanguageServer) clang2IdeWorkspaceEdit(logger jsonrpc.FunctionLogger, clangWorkspaceEdit *lsp.WorkspaceEdit) (*lsp.WorkspaceEdit, error) {
+	ideChanges := map[lsp.DocumentURI][]lsp.TextEdit{}
+	for clangURI, clangChanges := range clangWorkspaceEdit.Changes {
+		for _, clangTextEdit := range clangChanges {
+			ideURI, ideTextEdit, isPreprocessed, err := ls.clang2IdeTextEdit(logger, clangURI, clangTextEdit)
+			if isPreprocessed {
+				logger.Logf("- ignore edit in preprocessed area")
+				continue
+			}
+			if err != nil {
+				return nil, err
+			}
+			ideChanges[ideURI] = append(ideChanges[ideURI], ideTextEdit)
+		}
+	}
+	ideWorkspaceEdit := &lsp.WorkspaceEdit{
+		Changes:           ideChanges,
+		ChangeAnnotations: clangWorkspaceEdit.ChangeAnnotations,
+	}
+	return ideWorkspaceEdit, nil
+}
+
+func (ls *INOLanguageServer) clang2IdeTextEdit(logger jsonrpc.FunctionLogger, clangURI lsp.DocumentURI, clangTextEdit lsp.TextEdit) (lsp.DocumentURI, lsp.TextEdit, bool, error) {
+	ideURI, ideRange, isPreprocessed, err := ls.clang2IdeRangeAndDocumentURI(logger, clangURI, clangTextEdit.Range)
+	ideTextEdit := lsp.TextEdit{
+		NewText: clangTextEdit.NewText,
+		Range:   ideRange,
+	}
+	return ideURI, ideTextEdit, isPreprocessed, err
+}

ls/lsp_server_ide.go

@@ -155,7 +155,7 @@ func (server *IDELSPServer) TextDocumentOnTypeFormatting(ctx context.Context, lo
 }
 
 func (server *IDELSPServer) TextDocumentRename(ctx context.Context, logger jsonrpc.FunctionLogger, params *lsp.RenameParams) (*lsp.WorkspaceEdit, *jsonrpc.ResponseError) {
-	panic("unimplemented")
+	return server.ls.TextDocumentRenameReqFromIDE(ctx, logger, params)
 }
 
 func (server *IDELSPServer) TextDocumentFoldingRange(ctx context.Context, logger jsonrpc.FunctionLogger, params *lsp.FoldingRangeParams) ([]lsp.FoldingRange, *jsonrpc.ResponseError) {