Update library dependency installation dialog response indexes #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arduino libraries may specify dependencies on other libraries in their metadata. The installation of these dependencies is offered by the Arduino IDE when the user installs the dependent library using the Library Manager widget. The order of the buttons in the dialog that offers the dependencies installation was recently rearranged. The dialog response interpretation code was not updated to reflect the changes to the button indexes at that time. This caused the "CANCEL" button to trigger the behavior expected from the "INSTALL ALL" button, and vice versa. The library dependencies installation dialog response interpretation code is hereby updated to use the new button indexes.
per1234
added
topic: code
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Arduino libraries may specify dependencies on other libraries in their metadata. The installation of these dependencies is offered by Arduino IDE when the user installs the dependent library using the "Library Manager" widget.
The order of the buttons in the dialog that offers the dependencies installation was recently rearranged (#1382). The dialog response interpretation code was not updated to reflect the changes to the button indexes at that time. This caused the "CANCEL" button to trigger the behavior expected from the "INSTALL ALL" button, and vice versa.
To reproduce
ⓘ This library was picked arbitrarily. Any library that specifies dependencies can be used.
🐛 The dialog closes and no libraries are installed.
🐛 The notification and Output view show the "ArduinoIoTCloud" library and all dependencies being installed.
Change description
Update library dependency installation dialog response interpretation code to use the new button indexes.
Reviewer checklist