fix: revert unnecessary await

💄 test suite description + dev comments

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

arduino-ide-extension/src/test/node/core-client-provider.slow-test.ts

@@ -45,8 +45,10 @@ describe('core-client-provider', () => {
     });
   });
 
+  // The better translation the CLI has, the more likely IDE2 won't be able to detect primary package and library index errors.
+  // Instead of running the test against all supported locales, IDE2 runs the tests with locales that result in a bug.
   ['it', 'de'].map(([locale]) =>
-    it(`should recover from the missing 'directories.data' independently from the CLI locale: '${locale}'`, async function () {
+    it(`should recover when the 'directories.data' folder is missing independently from the CLI's locale ('${locale}')`, async function () {
       this.timeout(timeout);
       const configDirPath = await prepareTestConfigDir({ locale });
 
@@ -59,7 +61,7 @@ describe('core-client-provider', () => {
     })
   );
 
-  it("should recover all when the 'directories.data' folder is missing", async function () {
+  it("should recover when the 'directories.data' folder is missing", async function () {
     this.timeout(timeout);
     const configDirPath = await prepareTestConfigDir();
     deleteSync(join(configDirPath, 'data'));
@@ -106,7 +108,12 @@ describe('core-client-provider', () => {
   });
 
   ['serial-discovery', 'mdns-discovery'].map((tool) =>
-    it(`should recover the platform tools when the 'tools/${tool}' location is missing inside the 'directories.data/packages' folder`, async function () {
+    it(`should recover when the '${join(
+      'packages',
+      'builtin',
+      'tools',
+      tool
+    )}' folder is missing`, async function () {
       this.timeout(timeout);
       const configDirPath = await prepareTestConfigDir();
       const builtinToolsPath = join(

arduino-ide-extension/src/test/node/test-bindings.ts

@@ -407,7 +407,6 @@ export async function startDaemon(
     container.get<CoreClientProvider>(CoreClientProvider);
   toDispose.push(Disposable.create(() => daemon.stop()));
   configService.onStart();
-  await configService.getConfiguration(); // ensure the config service is ready with the modified `directories` props.
   daemon.onStart();
   await Promise.all([
     waitForEvent(daemon.onDaemonStarted, 10_000),