Improve checksum error

polldo · polldo · commit c9f916ec4b94 · 2021-12-09T16:43:30.000+01:00
diff --git a/internal/binary/download.go b/internal/binary/download.go
@@ -40,7 +40,7 @@ func Download(bin *IndexBin) ([]byte, error) {
 		return nil, fmt.Errorf("cannot retrieve binary size: %w", err)
 	}
 	if len(b) != int(sz) {
-		return nil, errors.New("download failed: invalid binary size")
+		return nil, fmt.Errorf("download failed: invalid binary size, expected %d bytes but got %d", sz, len(b))
 	}
 
 	err = fwuploader.VerifyChecksum(bin.Checksum, bytes.NewReader(b))

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ func Download(bin *IndexBin) ([]byte, error) {`
`40`	`40`	`return nil, fmt.Errorf("cannot retrieve binary size: %w", err)`
`41`	`41`	`}`
`42`	`42`	`if len(b) != int(sz) {`
`43`		`- return nil, errors.New("download failed: invalid binary size")`
	`43`	`+ return nil, fmt.Errorf("download failed: invalid binary size, expected %d bytes but got %d", sz, len(b))`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`err = fwuploader.VerifyChecksum(bin.Checksum, bytes.NewReader(b))`