The introduction of golangci-lint during the CI by mattiabertorello · Pull Request #24 · arduino/arduino-cli

Added linter configurations and disabled all the linters except golint

Mattia Bertorello

committed

Fixed almost all the problem reported by golint

Mattia Bertorello

committed

Fixed all the problem reported by misspell

Mattia Bertorello

committed

Fixed all the problem reported by gofmt

Mattia Bertorello

committed

Fixed all the problem reported by unconvert

Mattia Bertorello

committed

Fixed all the problem reported by nakedret

Mattia Bertorello

committed

Fixed all the problem reported by ineffassign ( ineffectual assignment)

Mattia Bertorello

committed

Fixed all the problem reported by interfacer (replace with the interface when is possible)

Mattia Bertorello

committed

Fixed all the problem reported by varcheck (unused variables)

Mattia Bertorello

committed

Fixed all the problem reported by lll (max line length set to 160)

Mattia Bertorello

committed

Added∂ golangci-lint run to the drone pipeline

Mattia Bertorello

committed

Removed unused code

Mattia Bertorello

committed

Removed comments and rename type1 to libType

Mattia Bertorello

committed

Apply style 2 in the flags (a line break before the description) https://github.com/arduino/arduino-cli/pull/24#discussion_r213709753

Mattia Bertorello

committed

Removed the name in the return parameters

Mattia Bertorello

committed

Convert error to lowercase

Mattia Bertorello

committed

Changed name of GetRelease to FindReleaseWith*

Mattia Bertorello

committed

Use a closure to avoid the defer called after the executeWithArgs method

Mattia Bertorello

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

The introduction of golangci-lint during the CI#24

The introduction of golangci-lint during the CI#24
cmaglie merged 18 commits intomasterfrom
make-the-linter-happy

Commits on Aug 30, 2018

Added linter configurations and disabled all the linters except golint

Fixed almost all the problem reported by golint

Fixed all the problem reported by misspell

Fixed all the problem reported by gofmt

Fixed all the problem reported by unconvert

Fixed all the problem reported by nakedret

Fixed all the problem reported by ineffassign ( ineffectual assignment)

Fixed all the problem reported by interfacer (replace with the interface when is possible)

Fixed all the problem reported by varcheck (unused variables)

Fixed all the problem reported by lll (max line length set to 160)

Added∂ golangci-lint run to the drone pipeline

Removed unused code

Removed comments and rename type1 to libType

Apply style 2 in the flags (a line break before the description) https://github.com/arduino/arduino-cli/pull/24#discussion_r213709753

Removed the name in the return parameters

Convert error to lowercase

Changed name of GetRelease to FindReleaseWith*

Use a closure to avoid the defer called after the executeWithArgs method

Uh oh!

The introduction of golangci-lint during the CI#24cmaglie merged 18 commits intomasterarduino/arduino-cli:masterfrom make-the-linter-happyarduino/arduino-cli:make-the-linter-happyCopy head branch name to clipboard

Commits

Commits on Aug 30, 2018

The introduction of golangci-lint during the CI#24
cmaglie merged 18 commits intomasterfrom
make-the-linter-happy