[skip-changelog] Fix copySketch testsuite function #1918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original copy sketch function written in conftest.py copies sketches into the testsuite's working directory. Changing the copy sketch function present in the golang testsuite to match the original one, should prevent errors that could occur while migrating tests.
MatteoPologruto
added
topic: infrastructure
cmaglie
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Infrastructure imperfection fix
What is the current behavior?
Sketches are copied into
SketchbookDir. This is not causing problems at the moment because, the tests that implement theCopySketch()function, use absolute paths. Nevertheless, this is incorrect and could cause problems when migrating other tests.What is the new behavior?
The original copy sketch function written in conftest.py copies sketches into the testsuite's working directory. Changing the copy sketch function present in the golang testsuite to match the original one, should prevent errors that could occur while migrating tests.
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information