[skip-changelog] Migrate tests from test_upgrade.py to upgrade_test.go
#1859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
Codecov Report
@@ Coverage Diff @@
## master #1859 +/- ##
==========================================
+ Coverage 36.66% 36.72% +0.06%
==========================================
Files 231 231
Lines 19609 19609
==========================================
+ Hits 7190 7202 +12
+ Misses 11594 11585 -9
+ Partials 825 822 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MatteoPologruto
force-pushed
the
upgrade-test-go
branch
from
68c9629 to
2b0837b
Compare
umbynos
reviewed
Sep 2, 2022
umbynos
approved these changes
Sep 2, 2022
umbynos
approved these changes
Sep 2, 2022
…py to upgrade_test.go
…deleted test_upgrade.py
MatteoPologruto
force-pushed
the
upgrade-test-go
branch
from
1dba5dd to
bf3c2f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Infrastructure Enhancement
What is the new behavior?
This PR is a followup to PR #1806
Integration tests that were previously present in
test_upgrade.pyhave been rewritten inupgrade_test.go, without changing their original purpose.The tests are the following:
Does this PR introduce a breaking change, and is titled accordingly?
No
See how to contribute