Skip to content

Portenta C33 SFU #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 4, 2023
Merged

Portenta C33 SFU #116

merged 4 commits into from
Sep 4, 2023

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Aug 31, 2023

No description provided.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Aug 31, 2023
per1234
per1234 previously requested changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the SFU library to .github/workflows/compile-examples.yml

@pennam
Copy link
Contributor Author

pennam commented Sep 4, 2023

Please add the SFU library to .github/workflows/compile-examples.yml

Thanks for the review @per1234 i've added the library to the compile-examples workflow as requested!

@pennam pennam requested a review from per1234 September 4, 2023 07:15
@per1234 per1234 dismissed their stale review September 4, 2023 07:52

Suggestions have all been resolved. Thanks!

@facchinm facchinm merged commit 65f003a into arduino:main Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 Awaiting requested review from per1234

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pennam @per1234 @facchinm