Added a rudimentary mechanism for reacting to messages from the host to the HID device. #6391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to the HID device. Fixes: arduino#6390
|
Oy, thanks for noticing that. I think I'll need to re-submit the PR to properly sort that... |
|
Re-submitted with the commit corrected: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a mechanism for reacting to messages from the host to the HID device. It's not a particularly lovely solution, but nicer mechanisms for callbacks (e.g. virtual methods, functors) would struggle with back compat. I'm not anything like an expert in this space, but I believe that HID devices really don't have a need for much more than what I've got here. It's enough to be able to do stuff like set keyboard LED's.
Fixes: #6930