Skip to content

Add includes field to Library Manager index and search scope #7604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
per1234 opened this issue May 17, 2018 · 1 comment
Closed

Add includes field to Library Manager index and search scope #7604

per1234 opened this issue May 17, 2018 · 1 comment
Labels
Component: Board/Lib Manager Boards Manager or Library Manager
Milestone

Comments

@per1234
Copy link
Collaborator

per1234 commented May 17, 2018

Often when searching for a dependency of someone's code the only information we have is the #include directive for the missing file and so that filename is the logical term to use in a Library Manager search query. That filename is not necessarily found in the library.properties fields currently used by the Library Manager search.

Adding the library.properties includes field to the Library Manager search scope will increase the chances of finding a library by searching for the primary header filename.

This will require adding that field to the Library Manager index JSON file.

@cmaglie
Copy link
Member

cmaglie commented May 22, 2018

The field is now available on the library_index.json as providesIncludes. I've extended the search on the Library Manager too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Board/Lib Manager Boards Manager or Library Manager
Projects
None yet
Development

No branches or pull requests

2 participants