-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Code will no longer compile after change in preprocessor #1687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I found out that the following line: https://github.com/TKJElectronics/Balanduino/blob/faae5a08d0a761a010e79b1656bac38036bd97f4/Firmware/Balanduino/Balanduino.ino#L59 is causing the problem. More specific it looks like the double slashes |
Added an "insideString" flag in scrubComments to avoid failing with strings like "Hello */*" Added a handful of tests taking code from various issues in order to better avoid future regressions Closes #1687
Fixed. Can you confirm and close the issue? (and so much thank you for the heads-up) |
Yes that commit solves the issue. Thanks ;) |
After the following commits: 12446a2 and 07f8c69. My code will no longer compile: https://github.com/TKJElectronics/Balanduino/tree/master/Firmware/Balanduino.
I tried reverting the commits and then it compiles just fine.
Here is my full error output:
The text was updated successfully, but these errors were encountered: