Saving window position and size

[willie68]

I'm working on an 1920x1080 screen and if i start the IDE the window is so small...
I would like to see, that the window position and the size is saved on leaving the IDE and restored on starting.

[sgk]

Window position and size will be saved if you quit the IDE with File->Quit menu, not by closing the window.

[willie68]

But why only by menu or the unusual CTRL+Q Command. I always close my app with ALT-F4 or by mouse clicking the cross.
In addition i would like to have the position and size data saved in combination with the sketch.

[sgk]

Ctrl-Q also works.

Alt-F4 closes wiondow, and results to stop IDE.

[willie68]

But why not saving on window close?

PS.: I found, if you close with CTRL-Q, the window position will be saved. But next time you close with ALT-F4 or Cross this settings will be overwritten...

[doby162]

I fixed the problem. I need to make a couple tweaks to my fix still, but I will post my solution soon. :) In my fix it works for alt-f4, the big red X, and CTRL-Q all the same way, and saves the screen size and position.

[willie68]

Still in 1.5.7

[willie68]

Still in 1.5.8
It's annoying, now CTRL-Q and the File->Quit menu doesn't work too.
Ahh,
CTRL-Q only works if you have loaded a sketch. Why?

[willie68]

Just 15 min in code digging, found out that last.sketch.count in preferences will be written on window close to 0 instead of the right number. Found out that

    // add listener to handle window close box hit event
    addWindowListener(new WindowAdapter() {
      public void windowClosing(WindowEvent e) {
        base.handleClose(Editor.this);
      }
    });

is wrong, because base.handleClose() is for closing one sketch editor. Must be base.handleQuit()

    // add listener to handle window close box hit event
    addWindowListener(new WindowAdapter() {
      public void windowClosing(WindowEvent e) {
        base.handleQuit();
      }
    });

Should i make a pull request?

[cmaglie]

Have you tested the patch with more than one sketch opened?
I suspect that this way when you open two (or more) sketches closing just one of them will completely close the app.

[willie68]

Yes you're right. I don't work with more than one sketch open. Just looking again.
The problem is, that in the base.handleClose() first the editor will be removed and after that storeSketches will be called. So i have put the storeSketchs() before the editors.remove() and that worked too.
I found this comment on the editors.remove:

      // This will store the sketch count as zero
      editors.remove(editor);

So this bug was already known. Maybe implemented with intent for debugging or something else?
OK, updated my repo.

[willie68]

Using 1.6.3, the same.
Ctrl-Q, File Close now working, but F4 or closing with the x doesn't work.