Fix: std::back_inserter already adds new elements, no need to reserve buffer before using std::back_inserter.

Doing so doubles the memory requirements.

Author: aentinger

examples/UDP_Client/UDP_Client.ino

@@ -121,6 +121,7 @@ void loop()
     prev_udp_packet_sent = now;
 
     /* Prepare UDP packet. */
+    uint8_t udp_tx_msg_buf[256] = {0};
     int const tx_packet_size = snprintf((char *)udp_tx_msg_buf, sizeof(udp_tx_msg_buf), "Single-Pair Ethernet / 10BASE-T1S: packet cnt = %d", tx_packet_cnt);
 
     /* Send a UDP packet to the UDP server. */

examples/UDP_Server/UDP_Server.ino

@@ -121,7 +121,7 @@ void loop()
   int const rx_packet_size = udp_server.parsePacket();
   if (rx_packet_size)
   {
-    std::vector<uint8_t> udp_tx_buf(rx_packet_size);
+    std::vector<uint8_t> udp_tx_buf;
     IPAddress const destination_ip = udp_server.remoteIP();
     uint16_t const destination_port = udp_server.remotePort();
 

src/Arduino_10BASE_T1S_UDP.cpp

@@ -129,7 +129,6 @@ size_t Arduino_10BASE_T1S_UDP::write(uint8_t data)
 
 size_t Arduino_10BASE_T1S_UDP::write(const uint8_t * buffer, size_t size)
 {
-  _tx_data.reserve(_tx_data.size() + size);
   std::copy(buffer, buffer + size, std::back_inserter(_tx_data));
   return size;
 }

src/Arduino_10BASE_T1S_UDP.h

@@ -95,8 +95,8 @@ class Arduino_10BASE_T1S_UDP : public UDP
       : _remote_ip(remote_ip)
       , _remote_port(remote_port)
       , _rx_data_len(data_len)
+      , _rx_data(p_data, p_data + data_len)
     {
-      std::copy(p_data, p_data + data_len, std::back_inserter(_rx_data));
     }
 
     typedef std::shared_ptr<UdpRxPacket> SharedPtr;