Skip to content

Generic variable names cause collisions #88

New issue
New issue
Open
#89
Open
Generic variable names cause collisions#88
#89
Labels
topic: codeRelated to content of the project itselftype: imperfectionPerceived defect in any part of project
@rin67630

Description

@rin67630
rin67630
opened on Jun 24, 2024

The ArduinoBearSSL library seem to create a problem:

Local\Arduino15\packages\esp8266\hardware\esp8266\3.1.2/tools/sdk/include/bearssl/bearssl_rand.h:205:16: note: in expansion of macro 'V'
  205 |  unsigned char V[64];

ArduinoBearSSL/src/bearssl/bearssl_rand.h

Lines 196 to 208 in d7a68ae

typedef struct {
/**
* \brief Pointer to the vtable.
*
* This field is set with the initialisation method/function.
*/
const br_prng_class *vtable;
#ifndef BR_DOXYGEN_IGNORE
unsigned char K[64];
unsigned char V[64];
const br_hash_class *digest_class;
#endif
} br_hmac_drbg_context;

Variables should not be named with capital letters, which conflicts with macros and constants.
Moreover it is recommended to take less generic names in libraries.

Metadata

Metadata

Assignees

No one assigned

    Labels

    topic: codeRelated to content of the project itselftype: imperfectionPerceived defect in any part of project

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions