Skip to content

gcc/clang warning fixes and CMake implementation #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 15, 2020

Conversation

jwinarske
Copy link
Contributor

@jwinarske jwinarske commented May 15, 2020

This implements a CMake build file, and fixes all build warnings for GCC 7.5 and Clang 6.

Using the CMake file you can build the executable on Linux desktop in one step. It will pull down engine archive for linux x64. If libgpiod is not installed on host, it won't set the define to include it.

mkdir build && cd build
cmake .. -GNinja
autoninja

x64 Engine channel selection defaults to stable if none is selected, otherwise you switch channels like this

cmake .. -DCHANNEL=stable
cmake .. -DCHANNEL=beta
cmake .. -DCHANNEL=dev
cmake .. -DCHANNEL=master

Or build in visual code with the CMake Vector Of Bool extension.

Also I added a reference to your project in my flutter_embedded project

Cheers,
Joel

Copy link
Owner

@ardera ardera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

There are a few things I'd change in the CMakeLists.txt though, so compilation on-target works as expected and the user has more freedom of choice for the engine used for compilation.

Other than that, looks great!

@ardera ardera merged commit 94f38d3 into ardera:master May 15, 2020
@ardera
Copy link
Owner

ardera commented May 15, 2020

Okay, looks good. Merged it.
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants