-
-
Notifications
You must be signed in to change notification settings - Fork 173
Libflutter engine rework #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modification to first try loading libflutter_engine.so from the asset bundle
ardera
reviewed
Feb 14, 2022
ardera
reviewed
Feb 26, 2022
ardera
reviewed
Feb 26, 2022
ardera
reviewed
Feb 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you fix the things I commented on it LGTM
ardera
reviewed
Jul 14, 2022
ardera
reviewed
Jul 14, 2022
ardera
reviewed
Jul 20, 2022
ardera
reviewed
Jul 20, 2022
ardera
reviewed
Jul 20, 2022
ardera
reviewed
Jul 20, 2022
ardera
reviewed
Jul 20, 2022
Co-authored-by: Hannes Winkler <[email protected]>
Co-authored-by: Hannes Winkler <[email protected]>
Co-authored-by: Hannes Winkler <[email protected]>
ardera
reviewed
Jul 20, 2022
ardera
reviewed
Jul 20, 2022
Co-authored-by: Hannes Winkler <[email protected]>
Co-authored-by: Hannes Winkler <[email protected]>
Co-authored-by: Hannes Winkler <[email protected]>
ardera
reviewed
Jul 20, 2022
ardera
reviewed
Jul 20, 2022
ardera
reviewed
Jul 20, 2022
ardera
reviewed
Jul 20, 2022
ardera
reviewed
Jul 20, 2022
few small things then it's done |
Co-authored-by: Hannes Winkler <[email protected]>
Co-authored-by: Hannes Winkler <[email protected]>
Co-authored-by: Hannes Winkler <[email protected]>
Co-authored-by: Hannes Winkler <[email protected]>
Co-authored-by: Hannes Winkler <[email protected]>
ardera
reviewed
Jul 20, 2022
Co-authored-by: Hannes Winkler <[email protected]>
Just tried running, I get an error when trying to run in profile mode. In line Line 2013 in e2d1853
runtime_mode == kProfile too, otherwise the app.so is not loaded.
|
ardera
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support profiling mode and ability to look for libflutter_engine.so in the asset bundle.