remove ATTR_PURE from ATTR_MALLOC method calls

- a function returning new memory can't be pure

Author: ardera

include/platformchannel.h

@@ -888,7 +888,7 @@ ATTR_PURE int64_t raw_std_value_as_int64(const struct raw_std_value *value);
 ATTR_PURE bool raw_std_value_is_float64(const struct raw_std_value *value);
 ATTR_PURE double raw_std_value_as_float64(const struct raw_std_value *value);
 ATTR_PURE bool raw_std_value_is_string(const struct raw_std_value *value);
-ATTR_PURE ATTR_MALLOC char *raw_std_string_dup(const struct raw_std_value *value);
+ATTR_MALLOC char *raw_std_string_dup(const struct raw_std_value *value);
 ATTR_PURE bool raw_std_string_equals(const struct raw_std_value *value, const char *str);
 ATTR_PURE bool raw_std_value_is_uint8array(const struct raw_std_value *value);
 ATTR_PURE const uint8_t *raw_std_value_as_uint8array(const struct raw_std_value *value);
@@ -924,7 +924,7 @@ ATTR_PURE bool raw_std_method_call_response_check(const struct raw_std_value *va
 ATTR_PURE bool raw_std_event_check(const struct raw_std_value *value, size_t buffer_size);
 
 ATTR_PURE const struct raw_std_value *raw_std_method_call_get_method(const struct raw_std_value *value);
-ATTR_PURE ATTR_MALLOC char *raw_std_method_call_get_method_dup(const struct raw_std_value *value);
+ATTR_MALLOC char *raw_std_method_call_get_method_dup(const struct raw_std_value *value);
 ATTR_PURE const struct raw_std_value *raw_std_method_call_get_arg(const struct raw_std_value *value);
 
 #define CONCAT(a, b) CONCAT_INNER(a, b)

src/platformchannel.c

@@ -1860,7 +1860,7 @@ ATTR_PURE bool raw_std_value_is_string(const struct raw_std_value *value) {
 	return raw_std_value_get_type(value) == kStdString;
 }
 
-ATTR_PURE ATTR_MALLOC char *raw_std_string_dup(const struct raw_std_value *value) {
+ATTR_MALLOC char *raw_std_string_dup(const struct raw_std_value *value) {
 	DEBUG_ASSERT(raw_std_value_is_string(value));
 
 	size_t size = raw_std_value_get_size(value);
@@ -2456,7 +2456,7 @@ ATTR_PURE bool raw_std_method_call_response_check(const struct raw_std_value *va
 
 	bool successful = (*(const uint8_t*) (value)) != 0;
 
-	value = (intptr_t) value + 1;
+	value = (void*) ((intptr_t) value + (intptr_t) 1);
 	buffer_size -= 1;
 
 	if (successful) {
@@ -2505,7 +2505,7 @@ ATTR_PURE const struct raw_std_value *raw_std_method_call_get_method(const struc
 	return value;
 }
 
-ATTR_MALLOC ATTR_PURE char *raw_std_method_call_get_method_dup(const struct raw_std_value *value) {
+ATTR_MALLOC char *raw_std_method_call_get_method_dup(const struct raw_std_value *value) {
 	DEBUG_ASSERT(raw_std_value_is_string(value));
 	return raw_std_string_dup(value);
 }