-
Notifications
You must be signed in to change notification settings - Fork 73
go mod fails on go 1.13 because of invalid pseudo-version #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ah, another one: Which means the official standpoint is:
|
Note also kubernetes/kubernetes#79384 (comment):
So it's a bit misleading to say that Kubernetes only supports Go 1.12. Rather, Kubernetes only supports use of their published subcomponents on 1.13, and presumably only at tagged releases, and still uses 1.12 internally. |
Hey, thanks for chiming in! 😊 Yes that's true. But also Kube is facing some other issues involved in switching to 1.13. But that's fine. Arango is still using 1.14 or so so its not like this is next week's trouble. |
I'm facing the issue above myself right now! My Dockerfile used to work fine, but now I'm getting the following error. Maybe you could give me a hand pointing out how I might go about fixing the compatibility issue I seem to be facing.
This is my Dockerfile
|
@RoyCrivolotti, per https://golang.org/doc/go1.13#version-validation, try (in your
and then run |
IDK exactly where that line is, aka what file it's in, so I'll comment the layers crashing the build, do the rest of the work work, get into the container with bash, and search in the uncompressed files for the line you say with |
No, I mean literally add that line somewhere in your module's |
Oh hahaha my bad, yeah that fixed it 100%. I didn't know where the go.mod file would be since I've never used this, so I just wen into the container with |
Once arango switches to go 1.13 the build will fail with this error:
This related to this:
golang/go#33546 from go.
And here is the related prometheus issue for it:
prometheus/prometheus#6048
TL;DR arango needs to get the commit ID instead of the version because prometheus doesn't care about go's API compatilibity restrictions.
The text was updated successfully, but these errors were encountered: