chore: fix double decoding of url params

aradjdi · aradjdi · commit beca9d2a535c · 2020-05-29T15:44:13.000+02:00
diff --git a/dist/vue-router.common.js b/dist/vue-router.common.js
@@ -2065,9 +2065,6 @@ function createRouterError (from, to, type, message) {
   error.to = to;
   error.type = type;
 
-  var newStack = error.stack.split('\n');
-  newStack.splice(1, 2); // remove 2 last useless calls
-  error.stack = newStack.join('\n');
   return error
 }
 
@@ -2663,7 +2660,7 @@ function getHash () {
     var hashIndex = href.indexOf('#');
     if (hashIndex > -1) {
       href = decodeURI(href.slice(0, hashIndex)) + href.slice(hashIndex);
-    } else { href = decodeURI(href); }
+    }
   } else {
     href = decodeURI(href.slice(0, searchIndex)) + href.slice(searchIndex);
   }
diff --git a/dist/vue-router.esm.browser.js b/dist/vue-router.esm.browser.js
@@ -2038,9 +2038,6 @@ function createRouterError (from, to, type, message) {
   error.to = to;
   error.type = type;
 
-  const newStack = error.stack.split('\n');
-  newStack.splice(1, 2); // remove 2 last useless calls
-  error.stack = newStack.join('\n');
   return error
 }
 
@@ -2625,7 +2622,7 @@ function getHash () {
     const hashIndex = href.indexOf('#');
     if (hashIndex > -1) {
       href = decodeURI(href.slice(0, hashIndex)) + href.slice(hashIndex);
-    } else href = decodeURI(href);
+    }
   } else {
     href = decodeURI(href.slice(0, searchIndex)) + href.slice(searchIndex);
   }
diff --git a/dist/vue-router.esm.browser.min.js b/dist/vue-router.esm.browser.min.js
diff --git a/dist/vue-router.esm.js b/dist/vue-router.esm.js
@@ -2063,9 +2063,6 @@ function createRouterError (from, to, type, message) {
   error.to = to;
   error.type = type;
 
-  var newStack = error.stack.split('\n');
-  newStack.splice(1, 2); // remove 2 last useless calls
-  error.stack = newStack.join('\n');
   return error
 }
 
@@ -2661,7 +2658,7 @@ function getHash () {
     var hashIndex = href.indexOf('#');
     if (hashIndex > -1) {
       href = decodeURI(href.slice(0, hashIndex)) + href.slice(hashIndex);
-    } else { href = decodeURI(href); }
+    }
   } else {
     href = decodeURI(href.slice(0, searchIndex)) + href.slice(searchIndex);
   }
diff --git a/dist/vue-router.js b/dist/vue-router.js
@@ -2069,9 +2069,6 @@
     error.to = to;
     error.type = type;
 
-    var newStack = error.stack.split('\n');
-    newStack.splice(1, 2); // remove 2 last useless calls
-    error.stack = newStack.join('\n');
     return error
   }
 
@@ -2667,7 +2664,7 @@
       var hashIndex = href.indexOf('#');
       if (hashIndex > -1) {
         href = decodeURI(href.slice(0, hashIndex)) + href.slice(hashIndex);
-      } else { href = decodeURI(href); }
+      }
     } else {
       href = decodeURI(href.slice(0, searchIndex)) + href.slice(searchIndex);
     }
diff --git a/dist/vue-router.min.js b/dist/vue-router.min.js
diff --git a/src/history/hash.js b/src/history/hash.js
@@ -132,7 +132,7 @@ export function getHash (): string {
     const hashIndex = href.indexOf('#')
     if (hashIndex > -1) {
       href = decodeURI(href.slice(0, hashIndex)) + href.slice(hashIndex)
-    } else href = decodeURI(href)
+    }
   } else {
     href = decodeURI(href.slice(0, searchIndex)) + href.slice(searchIndex)
   }

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ export function getHash (): string {`
`132`	`132`	`const hashIndex = href.indexOf('#')`
`133`	`133`	`if (hashIndex > -1) {`
`134`	`134`	`href = decodeURI(href.slice(0, hashIndex)) + href.slice(hashIndex)`
`135`		`- } else href = decodeURI(href)`
	`135`	`+ }`
`136`	`136`	`} else {`
`137`	`137`	`href = decodeURI(href.slice(0, searchIndex)) + href.slice(searchIndex)`
`138`	`138`	`}`